Index: server/config.c =================================================================== --- server/config.c (revision 1000188) +++ server/config.c (working copy) @@ -1112,11 +1112,11 @@ if (retval != NULL) return retval; - if (sub_tree == NULL && curr_parent != NULL) { + if (sub_tree == NULL) { sub_tree = *curr_parent; } - if (sub_tree == NULL && current != NULL) { + if (sub_tree == NULL) { sub_tree = *current; } } Index: server/util.c =================================================================== --- server/util.c (revision 1000188) +++ server/util.c (working copy) @@ -387,7 +387,7 @@ if (no > 9) { /* Ordinary character. */ if (c == '\\' && (*src == '$' || *src == '&')) - c = *src++; + src++; len++; } else if (no < nmatch && pmatch[no].rm_so < pmatch[no].rm_eo) { Index: server/core.c =================================================================== --- server/core.c (revision 1000188) +++ server/core.c (working copy) @@ -1840,13 +1840,6 @@ return missing_container_arg(cmd); } - if (!arg) { - if (thiscmd->cmd_data) - return " block must specify a path"; - else - return " block must specify a path"; - } - cmd->path = ap_getword_conf(cmd->pool, &arg); cmd->override = OR_ALL|ACCESS_CONF; Index: server/mpm_common.c =================================================================== --- server/mpm_common.c (revision 1000188) +++ server/mpm_common.c (working copy) @@ -965,7 +965,6 @@ apr_status_t rv; pid_t otherpid; int running = 0; - int have_pid_file = 0; const char *status; *exit_status = 0; @@ -983,7 +982,6 @@ status = "httpd (no pid file) not running"; } else { - have_pid_file = 1; if (kill(otherpid, 0) == 0) { running = 1; status = apr_psprintf(pconf, @@ -1058,12 +1056,10 @@ apr_getopt_t *opt; char optbuf[3]; const char *optarg; - int fixed_args; mpm_new_argv = apr_array_make(process->pool, process->argc, sizeof(const char **)); *(const char **)apr_array_push(mpm_new_argv) = process->argv[0]; - fixed_args = mpm_new_argv->nelts; apr_getopt_init(&opt, process->pool, process->argc, process->argv); opt->errfn = NULL; optbuf[0] = '-'; Index: server/scoreboard.c =================================================================== --- server/scoreboard.c (revision 1000188) +++ server/scoreboard.c (working copy) @@ -266,14 +266,12 @@ */ int ap_create_scoreboard(apr_pool_t *p, ap_scoreboard_e sb_type) { - int running_gen = 0; int i; #if APR_HAS_SHARED_MEMORY apr_status_t rv; #endif if (ap_scoreboard_image) { - running_gen = ap_scoreboard_image->global->running_generation; ap_scoreboard_image->global->restart_time = apr_time_now(); memset(ap_scoreboard_image->parent, 0, sizeof(process_score) * server_limit); @@ -315,7 +313,7 @@ } ap_scoreboard_image->global->sb_type = sb_type; - ap_scoreboard_image->global->running_generation = running_gen; + ap_scoreboard_image->global->running_generation = 0; ap_scoreboard_image->global->restart_time = apr_time_now(); apr_pool_cleanup_register(p, NULL, ap_cleanup_scoreboard, apr_pool_cleanup_null); Index: server/main.c =================================================================== --- server/main.c (revision 1000188) +++ server/main.c (working copy) @@ -321,15 +321,8 @@ static void usage(process_rec *process) { const char *bin = process->argv[0]; - char pad[MAX_STRING_LEN]; - unsigned i; + int pad_len = strlen(bin); - for (i = 0; i < strlen(bin); i++) { - pad[i] = ' '; - } - - pad[i] = '\0'; - #ifdef SHARED_CORE ap_log_error(APLOG_MARK, APLOG_STARTUP, 0, NULL , "Usage: %s [-R directory] [-D name] [-d directory] [-f file]", @@ -340,28 +333,28 @@ #endif ap_log_error(APLOG_MARK, APLOG_STARTUP, 0, NULL, - " %s [-C \"directive\"] [-c \"directive\"]", pad); + " %*s [-C \"directive\"] [-c \"directive\"]", pad_len, " "); #ifdef WIN32 ap_log_error(APLOG_MARK, APLOG_STARTUP, 0, NULL, - " %s [-w] [-k start|restart|stop|shutdown]", pad); + " %*s [-w] [-k start|restart|stop|shutdown]", pad_len, " "); ap_log_error(APLOG_MARK, APLOG_STARTUP, 0, NULL, - " %s [-k install|config|uninstall] [-n service_name]", - pad); + " %*s [-k install|config|uninstall] [-n service_name]", + pad_len, " "); #endif #ifdef AP_MPM_WANT_SIGNAL_SERVER #ifdef AP_MPM_WANT_SET_GRACEFUL_SHUTDOWN ap_log_error(APLOG_MARK, APLOG_STARTUP, 0, NULL, - " %s [-k start|restart|graceful|graceful-stop|stop]", - pad); + " %*s [-k start|restart|graceful|graceful-stop|stop]", + pad_len, " "); #else ap_log_error(APLOG_MARK, APLOG_STARTUP, 0, NULL, - " %s [-k start|restart|graceful|stop]", - pad); + " %*s [-k start|restart|graceful|stop]", pad_len, " "); #endif /* AP_MPM_WANT_SET_GRACEFUL_SHUTDOWN */ #endif ap_log_error(APLOG_MARK, APLOG_STARTUP, 0, NULL, - " %s [-v] [-V] [-h] [-l] [-L] [-t] [-T] [-S]", pad); + " %*s [-v] [-V] [-h] [-l] [-L] [-t] [-T] [-S]", + pad_len, " "); ap_log_error(APLOG_MARK, APLOG_STARTUP, 0, NULL, "Options:"); Index: modules/metadata/mod_cern_meta.c =================================================================== --- modules/metadata/mod_cern_meta.c (revision 1000188) +++ modules/metadata/mod_cern_meta.c (working copy) @@ -281,18 +281,18 @@ if (!dconf->metafiles) { return DECLINED; - }; + } /* if ./.web/$1.meta exists then output 'asis' */ if (r->finfo.filetype == 0) { return DECLINED; - }; + } /* is this a directory? */ if (r->finfo.filetype == APR_DIR || r->uri[strlen(r->uri) - 1] == '/') { return DECLINED; - }; + } /* what directory is this file in? */ scrap_book = apr_pstrdup(r->pool, r->filename); @@ -311,7 +311,7 @@ "internal error in mod_cern_meta: %s", r->filename); /* should really barf, but hey, let's be friends... */ return DECLINED; - }; + } metafilename = apr_pstrcat(r->pool, scrap_book, "/", dconf->metadir ? dconf->metadir : DEFAULT_METADIR, @@ -345,7 +345,7 @@ ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, "meta file permissions deny server access: %s", metafilename); return HTTP_FORBIDDEN; - }; + } /* read the headers in */ rv = scan_meta_file(r, f); Index: modules/mappers/mod_rewrite.c =================================================================== --- modules/mappers/mod_rewrite.c (revision 1000188) +++ modules/mappers/mod_rewrite.c (working copy) @@ -3180,7 +3180,7 @@ } /* determine the pattern type */ - newcond->ptype = 0; + newcond->ptype = CONDPAT_REGEX; if (*a2 && a2[1]) { if (!a2[2] && *a2 == '-') { switch (a2[1]) {